twuebi commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2413354958
> The problem is that table properties will only be respected by clients which know how to use it, so although you may set this property, you have no guarantee clients will follow the property. That is clear, we can prevent non-conforming clients from deleting stuff by not signing the respective request / handing out downscoped tokens without delete permissions. This would cause client side errors so eventually clients would have to conform if they want to talk to a catalog server with the UNDROP feature. > We can keep this a table property, but then it goes in the TableProperties file. Sure, I made it a catalog property since I agree with you, it's a property of the catalog and will likely not change on a per table basis. I had originally put it under table property since that's where the `s3.enable-delete` property was placed. > The implementation problem is that we already have several catalog implementations which are essentially client only which do not support a remote purge. For example [HiveCatalog](https://github.com/apache/iceberg/blob/e449d3405cfdb304c94835845bd8f34a73b4a517/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L250), [GlueCatalog](https://github.com/apache/iceberg/blob/cf02ffac4329141b30bca265cafb9987f64f6cc4/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L359-L360), [HadoopCatalog] ( > > https://github.com/apache/iceberg/blob/2446cee5cf0ad93a2be9a68f0b2f7f6fa6edb865/core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java#L264 > > ) > So this property is actually whether to use the "Catalog Purge" implementation which may or may not be on the client Could we prefix the property with something like rest-catalog to convince any client that they won't have an effect against the other catalogs for which this flag doesn't have a meaning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
