RussellSpitzer commented on PR #11317: URL: https://github.com/apache/iceberg/pull/11317#issuecomment-2412029752
The problem is that table properties will only be respected by clients which know how to use it, so although you may set this property, you have no guarantee clients will follow the property. We can keep this a table property, but then it goes in the TableProperties file. The implementation problem is that we already have several catalog implementations which are essentially client only which do not support a remote purge. For example [HiveCatalog](https://github.com/apache/iceberg/blob/e449d3405cfdb304c94835845bd8f34a73b4a517/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L250), [GlueCatalog](https://github.com/apache/iceberg/blob/cf02ffac4329141b30bca265cafb9987f64f6cc4/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L359-L360), [HadoopCatalog] https://github.com/apache/iceberg/blob/2446cee5cf0ad93a2be9a68f0b2f7f6fa6edb865/core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java#L264 So this property is actually whether to use the "Catalog Purge" implementation which may or may not be on the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
