twuebi commented on code in PR #11317:
URL: https://github.com/apache/iceberg/pull/11317#discussion_r1829207481
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -60,6 +60,10 @@ public static Catalog wrap(
return new CachingCatalog(catalog, caseSensitive,
expirationIntervalMillis);
}
+ public boolean wrapped_is_instance(Class<?> cls) {
Review Comment:
This is used for checking the type of the catalog impl that `CachingCatalog`
is wrapping so that we can correctly respect the purge property at
https://github.com/apache/iceberg/pull/11317/files#diff-bd61838d4e3a9aef52a670696750b30deac10b90f526435e32beacb0107eea24R376.
Unless `CachingCatalog` is only used in tests, I think we need to keep this
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
