Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

amogh-jahagirdar merged PR #11175: URL: https://github.com/apache/iceberg/pull/11175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

amogh-jahagirdar commented on PR #11175: URL: https://github.com/apache/iceberg/pull/11175#issuecomment-2375505084 Thanks @wypoon , merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

wypoon commented on PR #11175: URL: https://github.com/apache/iceberg/pull/11175#issuecomment-2374694585 The Flink CI issues are unrelated to this change. All tests passed prior to my last commit, and the only change in the last commit was updating javadoc comments. -- This is an automat

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

amogh-jahagirdar commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1775363242 ## core/src/test/java/org/apache/iceberg/deletes/TestPositionFilter.java: ## @@ -110,155 +106,6 @@ public void testPositionMerging() { .containsExac

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

amogh-jahagirdar commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1775368555 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,29 +185,6 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable p

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

wypoon commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1775347390 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,27 +185,43 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable posDel

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

nastra commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1774877596 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,27 +185,43 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable posDel

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

nastra commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1774876614 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,27 +185,43 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable posDel

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

wypoon commented on PR #11175: URL: https://github.com/apache/iceberg/pull/11175#issuecomment-2364760327 @amogh-jahagirdar I have restored the removed public static methods in `Deletes` and deprecated them instead. However, I have replaced their implementations with the equivalent of using

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

wypoon commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1769273124 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,29 +185,6 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable posDel

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

amogh-jahagirdar commented on code in PR #11175: URL: https://github.com/apache/iceberg/pull/11175#discussion_r1769208491 ## core/src/main/java/org/apache/iceberg/deletes/Deletes.java: ## @@ -192,29 +185,6 @@ public static PositionDeleteIndex toPositionIndex(CloseableIterable p

Re: [PR] Core: Remove unused code for streaming position deletes [iceberg]

wypoon commented on PR #11175: URL: https://github.com/apache/iceberg/pull/11175#issuecomment-2364531622 @amogh-jahagirdar @szehon-ho @aokolnychyi please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL