wypoon commented on PR #11175: URL: https://github.com/apache/iceberg/pull/11175#issuecomment-2364760327
@amogh-jahagirdar I have restored the removed public static methods in `Deletes` and deprecated them instead. However, I have replaced their implementations with the equivalent of using the non-streaming code path. See https://github.com/apache/iceberg/blob/a3849bfa5c360dea7afeaf6bed2750b8b13ef2cd/data/src/main/java/org/apache/iceberg/data/DeleteFilter.java#L248-L260 and https://github.com/apache/iceberg/blob/a3849bfa5c360dea7afeaf6bed2750b8b13ef2cd/data/src/main/java/org/apache/iceberg/data/DeleteFilter.java#L262-L267 for reference. The same change is in https://github.com/apache/iceberg/pull/11177 except there the tests using `Deletes.streamingFilter` and `Deletes.streamingMarker` have not been removed, so you can see that the tests pass (for myself, I ran the tests locally). Since the objective is to remove code, I did not want to restore the tests here. https://github.com/apache/iceberg/pull/11177 is not intended for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
