wypoon commented on code in PR #11175:
URL: https://github.com/apache/iceberg/pull/11175#discussion_r1769273124
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -192,29 +185,6 @@ public static PositionDeleteIndex
toPositionIndex(CloseableIterable<Long> posDel
}
}
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes) {
- return streamingFilter(rows, rowToPosition, posDeletes, new
DeleteCounter());
- }
-
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- DeleteCounter counter) {
- return new PositionStreamDeleteFilter<>(rows, rowToPosition, posDeletes,
counter);
- }
-
- public static <T> CloseableIterable<T> streamingMarker(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- Consumer<T> markDeleted) {
- return new PositionStreamDeleteMarker<>(rows, rowToPosition, posDeletes,
markDeleted);
- }
-
Review Comment:
I'd argue that `Deletes` is actually a utility class with just utility
functions (static methods), and the reason it is public is that the functions
are called from another module (data). As such, I think it is a bit different.
However, if you insist, I'll deprecate the static methods for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
