amogh-jahagirdar commented on code in PR #11175:
URL: https://github.com/apache/iceberg/pull/11175#discussion_r1775363242
##########
core/src/test/java/org/apache/iceberg/deletes/TestPositionFilter.java:
##########
@@ -110,155 +106,6 @@ public void testPositionMerging() {
.containsExactly(0L, 3L, 3L, 9L, 16L, 19L, 19L, 22L, 22L, 56L, 63L,
70L, 91L);
}
- @Test
- public void testPositionStreamRowFilter() {
Review Comment:
I tend to prefer not removing the tests until the deprecated method is
actually removed from the code, but I think in this case it's fine since it's
not a typical public API and rather a utility.
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -192,29 +185,6 @@ public static PositionDeleteIndex
toPositionIndex(CloseableIterable<Long> posDel
}
}
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes) {
- return streamingFilter(rows, rowToPosition, posDeletes, new
DeleteCounter());
- }
-
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- DeleteCounter counter) {
- return new PositionStreamDeleteFilter<>(rows, rowToPosition, posDeletes,
counter);
- }
-
- public static <T> CloseableIterable<T> streamingMarker(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- Consumer<T> markDeleted) {
- return new PositionStreamDeleteMarker<>(rows, rowToPosition, posDeletes,
markDeleted);
- }
-
Review Comment:
Thanks! Yeah I recognize it's a utility that's unlikely to be used elsewhere
but the unfortunate thing about methods/classes being public is we never truly
know who is actually using it and it's difficult to make assumptions there. So
we opt for deprecating to give people a chance to get off of it, and then we
remove in a later version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
