amogh-jahagirdar commented on code in PR #11175:
URL: https://github.com/apache/iceberg/pull/11175#discussion_r1775368555
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -192,29 +185,6 @@ public static PositionDeleteIndex
toPositionIndex(CloseableIterable<Long> posDel
}
}
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes) {
- return streamingFilter(rows, rowToPosition, posDeletes, new
DeleteCounter());
- }
-
- public static <T> CloseableIterable<T> streamingFilter(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- DeleteCounter counter) {
- return new PositionStreamDeleteFilter<>(rows, rowToPosition, posDeletes,
counter);
- }
-
- public static <T> CloseableIterable<T> streamingMarker(
- CloseableIterable<T> rows,
- Function<T, Long> rowToPosition,
- CloseableIterable<Long> posDeletes,
- Consumer<T> markDeleted) {
- return new PositionStreamDeleteMarker<>(rows, rowToPosition, posDeletes,
markDeleted);
- }
-
Review Comment:
Thanks! Yeah I recognize it's a utility that's unlikely to be used elsewhere
but the unfortunate thing about methods/classes being public is we never truly
know who is actually using it and it's difficult to make assumptions there. So
we opt for deprecating to indicate to folks to get off of it for at least one
version, and then we remove in a later version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
