rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1492788744
##
core/src/test/java/org/apache/iceberg/view/TestViewMetadata.java:
##
@@ -63,8 +62,11 @@ public void testExpiration() {
ViewVersion v2 = newViewVersion(2, "select
amogh-jahagirdar commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1491191209
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -504,6 +517,11 @@ static List
updateHistory(List history, Set<
}
}
+
amogh-jahagirdar commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1491185660
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -504,6 +517,11 @@ static List
updateHistory(List history, Set<
}
}
+
nastra merged PR #9725:
URL: https://github.com/apache/iceberg/pull/9725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#issuecomment-1945601409
@amogh-jahagirdar @rdblue I've rolled back all changes around version
expiration and updating the history. I've improved testing coverage around
these so that it's clearer that the size of
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490603721
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -479,21 +488,21 @@ public ViewMetadata build() {
metadataLocation);
}
-stati
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490598286
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -504,6 +517,11 @@ static List
updateHistory(List history, Set<
}
}
+ // ke
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490501986
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -438,6 +439,10 @@ public ViewMetadata build() {
metadataLocation == null || changes.isE
rdblue commented on PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#issuecomment-1945201021
Also, to keep things moving: +1 when the changes to `expireVersions` and
`updateHistory` are removed. The simple fix to update history only once per
commit looks good.
--
This is an aut
rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490244193
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -504,6 +517,11 @@ static List
updateHistory(List history, Set<
}
}
+ // ke
rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490242520
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -479,21 +488,21 @@ public ViewMetadata build() {
metadataLocation);
}
-stati
rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490236966
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -479,21 +488,21 @@ public ViewMetadata build() {
metadataLocation);
}
-stati
rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490235686
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -243,6 +244,12 @@ public Builder setCurrentVersionId(int newVersionId) {
changes.add(new
amogh-jahagirdar commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490117508
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -438,6 +439,10 @@ public ViewMetadata build() {
metadataLocation == null || c
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489631189
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -479,21 +488,21 @@ public ViewMetadata build() {
metadataLocation);
}
-stati
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489628489
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -479,21 +488,21 @@ public ViewMetadata build() {
metadataLocation);
}
-stati
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489559055
##
core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java:
##
@@ -101,16 +101,20 @@ public void readAndWriteValidViewMetadata() throws
Exception {
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489553738
##
core/src/test/java/org/apache/iceberg/view/TestViewMetadata.java:
##
@@ -252,12 +301,12 @@ public void viewHistoryNormalization() {
// the first build will not
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489547283
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -504,6 +517,11 @@ static List
updateHistory(List history, Set<
}
}
+ // ke
nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489543649
##
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##
@@ -485,15 +496,17 @@ static List expireVersions(
List ids = Lists.newArrayList(versionsById.k
20 matches
Mail list logo
