rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1492788744
##########
core/src/test/java/org/apache/iceberg/view/TestViewMetadata.java:
##########
@@ -63,8 +62,11 @@ public void testExpiration() {
ViewVersion v2 = newViewVersion(2, "select count(1) as count from t2");
Map<Integer, ViewVersion> versionsById = ImmutableMap.of(1, v1, 2, v2, 3,
v3);
- List<ViewVersion> retainedVersions =
ViewMetadata.Builder.expireVersions(versionsById, 2);
- assertThat(retainedVersions).hasSameElementsAs(ImmutableList.of(v2, v3));
+ assertThat(ViewMetadata.Builder.expireVersions(versionsById, 3))
+ .containsExactlyInAnyOrder(v1, v2, v3);
Review Comment:
@nastra, why did this change to `containsExactlyInAnyOrder`? Shouldn't the
order be predictable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
