rdblue commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1490244193
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -504,6 +517,11 @@ static List<ViewHistoryEntry>
updateHistory(List<ViewHistoryEntry> history, Set<
}
}
+ // keep the last numVersionsToKeep in the history
Review Comment:
@nastra, I don't think this change is a good idea. The `numVersionsToKeep`
option applies to versions, not history. History is retained as long as it
references valid versions.
There's no expectation that history and versions have the same size. History
will have entries that are independent from versions. For example, if I run
`CREATE OR REPLACE` and add a new version then I create both a version and a
history entry. But if I roll back that change by setting the current version,
no versions are added but the history is updated to show that the current
version went from 2 to 1 (for example).
I don't think we need to update this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
