nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489553738


##########
core/src/test/java/org/apache/iceberg/view/TestViewMetadata.java:
##########
@@ -252,12 +301,12 @@ public void viewHistoryNormalization() {
 
     // the first build will not expire versions that were added in the builder
     assertThat(originalViewMetadata.versions()).hasSize(3);
-    assertThat(originalViewMetadata.history()).hasSize(3);
+    assertThat(originalViewMetadata.history()).hasSize(1);
 
     // rebuild the metadata to expire older versions
     ViewMetadata viewMetadata = 
ViewMetadata.buildFrom(originalViewMetadata).build();
     assertThat(viewMetadata.versions()).hasSize(2);
-    assertThat(viewMetadata.history()).hasSize(2);
+    assertThat(viewMetadata.history()).hasSize(1);

Review Comment:
   nothing changed, so history should stay at 1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to