nastra commented on code in PR #9725:
URL: https://github.com/apache/iceberg/pull/9725#discussion_r1489547283
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -504,6 +517,11 @@ static List<ViewHistoryEntry>
updateHistory(List<ViewHistoryEntry> history, Set<
}
}
+ // keep the last numVersionsToKeep in the history
Review Comment:
previously the code implied that `history` and `versions` would have the
same size, but that isn't true, because the history is now only updated when
`setCurrentVersionId(..)` is being called -> keep only the last
`numVersionsToKeep` in the history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
