Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-06-03 Thread via GitHub
amogh-jahagirdar merged PR #10161: URL: https://github.com/apache/iceberg/pull/10161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-06-03 Thread via GitHub
nastra commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1624310832 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -458,32 +458,11 @@ public static class AuthSession { private static final long MAX_REFRE

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1606204569 ## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java: ## @@ -458,32 +458,11 @@ public static class AuthSession { private static final long

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-18 Thread via GitHub
nastra commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1605699574 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-17 Thread via GitHub
dramaticlly commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1605376803 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-17 Thread via GitHub
nastra commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1604457662 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-16 Thread via GitHub
dramaticlly commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1604193353 ## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-08 Thread via GitHub
flyrain commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1594289258 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -213,12 +214,13 @@ private AuthSession authSession() { e

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-07 Thread via GitHub
nastra commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1592491274 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -213,12 +214,13 @@ private AuthSession authSession() { ex

Re: [PR] Core: Introduce AuthConfig [iceberg]

2024-05-04 Thread via GitHub
flyrain commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1590183580 ## aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java: ## @@ -213,12 +214,13 @@ private AuthSession authSession() { e