flyrain commented on code in PR #10161:
URL: https://github.com/apache/iceberg/pull/10161#discussion_r1590183580
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -213,12 +214,13 @@ private AuthSession authSession() {
expiresAtMillis(properties()),
new AuthSession(
ImmutableMap.of(),
- token,
- null,
- credential(),
- SCOPE,
- oauth2ServerUri(),
- optionalOAuthParams())));
+ AuthConfig.builder()
+ .token(token)
+ .credential(credential())
+ .scope(SCOPE)
Review Comment:
I'd consider `SCOPE` as one of the optional params. It is optional in both
[token exchange
flow](https://datatracker.ietf.org/doc/html/rfc8693#name-token-exchange-request-and-)
and [client credential
flow](https://datatracker.ietf.org/doc/html/rfc6749#section-4.4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
