nastra commented on code in PR #10161: URL: https://github.com/apache/iceberg/pull/10161#discussion_r1604457662
########## core/src/main/java/org/apache/iceberg/rest/auth/AuthConfig.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.auth; + +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.iceberg.rest.ResourcePaths; +import org.immutables.value.Value; + +@Value.Style(redactedMask = "****") +@SuppressWarnings("ImmutablesStyle") +@Value.Immutable +public interface AuthConfig { Review Comment: > Also I am unclear on whether we can implement a custom AuthConfig to account for proprietary token generation which is not Oauth2 `AuthConfig` is directly related to `AuthSession` and controls the behavior of it, which in turn is OAuth2. Also it's an Immutable interface where the implementation will be generated from (rather than having to implement something by hand). I've added some javadoc to point out that the purpose of `AuthConfig` is to hold configuration options from `AuthSession`. Hopefully that makes it clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
