nastra commented on code in PR #10161:
URL: https://github.com/apache/iceberg/pull/10161#discussion_r1592491274
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -213,12 +214,13 @@ private AuthSession authSession() {
expiresAtMillis(properties()),
new AuthSession(
ImmutableMap.of(),
- token,
- null,
- credential(),
- SCOPE,
- oauth2ServerUri(),
- optionalOAuthParams())));
+ AuthConfig.builder()
+ .token(token)
+ .credential(credential())
+ .scope(SCOPE)
Review Comment:
yes `SCOPE` is optional, but the signer client uses a custom scope, which we
need to provide here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
