flyrain commented on code in PR #10161:
URL: https://github.com/apache/iceberg/pull/10161#discussion_r1594289258
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -213,12 +214,13 @@ private AuthSession authSession() {
expiresAtMillis(properties()),
new AuthSession(
ImmutableMap.of(),
- token,
- null,
- credential(),
- SCOPE,
- oauth2ServerUri(),
- optionalOAuthParams())));
+ AuthConfig.builder()
+ .token(token)
+ .credential(credential())
+ .scope(SCOPE)
Review Comment:
We can get the scope from the optional OAuth parameters for signer. Also a
rest catalog isn't necessary with signer. But I'm OK with either one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
