Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-19 Thread via GitHub
sungwy merged PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-19 Thread via GitHub
sungwy commented on PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#issuecomment-2362470444 Thanks for making this contribution @soumya-ghosh ! And thank you @kevinjqliu and @ndrluis for the detailed reviews! -- This is an automated message from the Apache Git Service. T

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-12 Thread via GitHub
kevinjqliu commented on PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#issuecomment-2347426984 thanks again @soumya-ghosh. I'll wait for another approval before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-12 Thread via GitHub
sungwy commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1757539710 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null) -

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-12 Thread via GitHub
soumya-ghosh commented on PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#issuecomment-2347169831 @sungwy @Fokko could you review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-12 Thread via GitHub
soumya-ghosh commented on PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#issuecomment-2347042844 @kevinjqliu could you execute the workflow for this? I've merged this PR into refactored __init__.py. Also wanted to check if integration tests are failing here. -- This is

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-03 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1742582633 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-03 Thread via GitHub
kevinjqliu commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1742555465 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null)

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-03 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1742512075 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-03 Thread via GitHub
kevinjqliu commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1742483484 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null)

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-02 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1741247300 ## pyiceberg/table/__init__.py: ## @@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table": return pa.Table.from_pylist(history, schema=history_sch

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-02 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1741244086 ## mkdocs/docs/api.md: ## @@ -844,6 +844,19 @@ readable_metrics: [ [6.0989]] ``` + Review Comment: Okay, removing it. I was not sure what this did i

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-02 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1741239066 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
kevinjqliu commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740179090 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null)

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
kevinjqliu commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740179023 ## pyiceberg/table/__init__.py: ## @@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table": return pa.Table.from_pylist(history, schema=history_schem

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740159747 ## pyiceberg/table/__init__.py: ## @@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table": return pa.Table.from_pylist(history, schema=history_sch

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740158950 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740157217 ## tests/integration/test_inspect_table.py: ## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-01 Thread via GitHub
kevinjqliu commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740141923 ## mkdocs/docs/api.md: ## @@ -844,6 +844,19 @@ readable_metrics: [ [6.0989]] ``` + Review Comment: with the new markdown linter (#1118), this might no

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-08-16 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719803725 ## pyiceberg/table/__init__.py: ## @@ -4365,6 +4365,10 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: for manifest_l

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-08-16 Thread via GitHub
soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719782196 ## pyiceberg/table/__init__.py: ## @@ -4393,12 +4397,12 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: "

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-08-15 Thread via GitHub
ndrluis commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719186698 ## pyiceberg/table/__init__.py: ## @@ -4393,12 +4397,12 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: "spec_

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-08-15 Thread via GitHub
ndrluis commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719185549 ## pyiceberg/table/__init__.py: ## @@ -4365,6 +4365,10 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: for manifest_list i

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-08-15 Thread via GitHub
ndrluis commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719185549 ## pyiceberg/table/__init__.py: ## @@ -4365,6 +4365,10 @@ def _readable_metrics_struct(bound_type: PrimitiveType) -> pa.StructType: for manifest_list i