ndrluis commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1719185549
##########
pyiceberg/table/__init__.py:
##########
@@ -4365,6 +4365,10 @@ def _readable_metrics_struct(bound_type: PrimitiveType)
-> pa.StructType:
for manifest_list in snapshot.manifests(io):
for manifest_entry in manifest_list.fetch_manifest_entry(io):
data_file = manifest_entry.data_file
+ if file_content_type == "data" and data_file.content !=
DataFileContent.DATA:
+ continue
+ if file_content_type == "delete" and data_file.content ==
DataFileContent.DATA:
Review Comment:
What do you think about moving the file_content_type options to a constants
module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
