soumya-ghosh commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740159747
##########
pyiceberg/table/__init__.py:
##########
@@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
- def files(self, snapshot_id: Optional[int] = None) -> "pa.Table":
+ def _files(
+ self, snapshot_id: Optional[int] = None, data_file_content_types:
Optional[List[DataFileContent]] = None
Review Comment:
What would be benefit of using a Set instead of List? `_files` is not a
public function and the list also contains 2 elements at max. Are you
suggesting it because class member functions are not really private, thus to
prevent abuse of `_files`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
