kevinjqliu commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740179023
##########
pyiceberg/table/__init__.py:
##########
@@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schema)
- def files(self, snapshot_id: Optional[int] = None) -> "pa.Table":
+ def _files(
+ self, snapshot_id: Optional[int] = None, data_file_content_types:
Optional[List[DataFileContent]] = None
Review Comment:
prefer Set since it doesnt make sense to pass in multiple of the same data
file types.
https://github.com/apache/iceberg-python/pull/1066/files#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bR4418-R4425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
