soumya-ghosh commented on code in PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1742512075
########## tests/integration/test_inspect_table.py: ########## @@ -672,126 +672,141 @@ def test_inspect_files( # append more data tbl.append(arrow_table_with_null) - df = tbl.refresh().inspect.files() + # configure table properties + if format_version == 2: + with tbl.transaction() as txn: + txn.set_properties({"write.delete.mode": "merge-on-read"}) + spark.sql(f"DELETE FROM {identifier} WHERE int = 1") Review Comment: Spark streaming might produce equality deletes, I tried with Flink, created an Iceberg table and upserted some data into it, observed that there were both positional and equality deletes files, which looked weird to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org