flyrain commented on PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#issuecomment-2024066123
Thanks for @whynick1 for working on this. Thanks @liurenjie1024 @Fokko for
the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
flyrain merged PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541552671
##
crates/catalog/rest/src/catalog.rs:
##
@@ -963,6 +993,76 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541552671
##
crates/catalog/rest/src/catalog.rs:
##
@@ -963,6 +993,76 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541504517
##
crates/catalog/rest/src/catalog.rs:
##
@@ -103,8 +104,7 @@ impl RestCatalogConfig {
])
}
-fn try_create_rest_client(&self) -> Result {
-
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541494804
##
crates/catalog/rest/src/catalog.rs:
##
@@ -963,6 +993,76 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
Fokko commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541090474
##
crates/catalog/rest/src/catalog.rs:
##
@@ -963,6 +993,76 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
liurenjie1024 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540327433
##
crates/catalog/rest/src/catalog.rs:
##
@@ -103,8 +104,7 @@ impl RestCatalogConfig {
])
}
-fn try_create_rest_client(&self) -> Result {
-
liurenjie1024 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540327945
##
crates/catalog/rest/src/catalog.rs:
##
@@ -103,8 +104,7 @@ impl RestCatalogConfig {
])
}
-fn try_create_rest_client(&self) -> Result {
-
flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540253733
##
crates/catalog/rest/src/catalog.rs:
##
@@ -103,8 +104,7 @@ impl RestCatalogConfig {
])
}
-fn try_create_rest_client(&self) -> Result {
-
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540191330
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540153323
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540025945
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
whynick1 commented on PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#issuecomment-2021248780
Note: CI check failed due to a known issue
https://github.com/apache/iceberg-rust/issues/307, which has been fixed. Rerun
build should success.
--
This is an automated message fro
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1539932487
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1539932487
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1539833388
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
liurenjie1024 commented on PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#issuecomment-2020044992
cc @flyrain PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
whynick1 commented on PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#issuecomment-2019455618
@flyrain @liurenjie1024 Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1538626859
##
crates/catalog/rest/src/catalog.rs:
##
@@ -956,6 +983,68 @@ mod tests {
);
}
+#[tokio::test]
+async fn test_get_default_headers() {
+
whynick1 commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1538626596
##
crates/catalog/rest/src/catalog.rs:
##
@@ -130,6 +130,33 @@ impl RestCatalogConfig {
);
}
+for (key, value) in self.props.iter()
21 matches
Mail list logo
