flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1541552671


##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -963,6 +993,76 @@ mod tests {
         );
     }
 
+    #[tokio::test]
+    async fn test_get_default_headers() {
+        let server = Server::new_async().await;
+        let mut props = HashMap::new();
+        props.insert("credential".to_string(), "client1:secret1".to_string());
+
+        let config = RestCatalogConfig::builder()
+            .uri(server.url())
+            .props(props)
+            .build();
+        let headers: HeaderMap = config.get_default_headers().unwrap();
+
+        let expected_headers = HeaderMap::from_iter([
+            (
+                header::CONTENT_TYPE,
+                HeaderValue::from_static("application/json"),
+            ),
+            (
+                HeaderName::from_static("x-client-version"),
+                HeaderValue::from_static(ICEBERG_REST_SPEC_VERSION),
+            ),
+            (
+                header::USER_AGENT,
+                HeaderValue::from_str(&format!("iceberg-rs/{}", 
CARGO_PKG_VERSION)).unwrap(),
+            ),
+        ]);
+        assert_eq!(headers, expected_headers);
+    }
+
+    #[tokio::test]
+    async fn test_get_default_headers_with_custom_headers() {
+        let server = Server::new_async().await;
+        let mut props = HashMap::new();
+        props.insert("credential".to_string(), "client1:secret1".to_string());
+        props.insert(
+            "header.content-type".to_string(),

Review Comment:
   Checked the Java and Python's implementation. Both are without `rest.`  for 
headers. I'd be nice to have a `rest.` prefix. It doesn't seem a blocker to me 
though.
   
   pyIceberg doc from https://github.com/apache/iceberg-python/pull/467:
   ```yaml
   catalog:
     default:
       uri: http://rest-catalog/ws/
       credential: t-1234:secret
       header.content-type: application/vnd.api+json
   ```
   
   Java config example
   ```
   spark.sql.catalog.my-catalog.header.X-Catalog-Name=default 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to