liurenjie1024 commented on code in PR #306: URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540327945
########## crates/catalog/rest/src/catalog.rs: ########## @@ -103,8 +104,7 @@ impl RestCatalogConfig { ]) } - fn try_create_rest_client(&self) -> Result<HttpClient> { - // TODO: We will add ssl config, sigv4 later + fn get_default_headers(&self) -> Result<HeaderMap> { Review Comment: cc @whynick1 Would you mind to do this rename in this pr or in following prs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org