flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1540253733
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -103,8 +104,7 @@ impl RestCatalogConfig {
])
}
- fn try_create_rest_client(&self) -> Result<HttpClient> {
- // TODO: We will add ssl config, sigv4 later
+ fn get_default_headers(&self) -> Result<HeaderMap> {
Review Comment:
Minor: we may simplify the name to `headers()` or `http_headers()`, this is
consistent with other function name like `table_endpoint`, `url_prefixed`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
