flyrain commented on code in PR #306:
URL: https://github.com/apache/iceberg-rust/pull/306#discussion_r1539833388
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -956,6 +983,68 @@ mod tests {
);
}
+ #[tokio::test]
+ async fn test_get_default_headers() {
+ let server = Server::new_async().await;
+ let mut props = HashMap::new();
+ props.insert("credential".to_string(), "client1:secret1".to_string());
+
+ let config = RestCatalogConfig::builder()
+ .uri(server.url())
+ .props(props)
+ .build();
+ let headers: HeaderMap = config.get_default_headers().unwrap();
+
+ let expected_headers = HeaderMap::from_iter([
+ (
+ header::CONTENT_TYPE,
+ HeaderValue::from_static("application/json"),
+ ),
+ (
+ HeaderName::from_static("x-client-version"),
+ HeaderValue::from_static(ICEBERG_REST_SPEC_VERSION),
+ ),
+ (
+ header::USER_AGENT,
+ HeaderValue::from_str(&format!("iceberg-rs/{}",
CARGO_PKG_VERSION)).unwrap(),
+ ),
+ ]);
+ assert_eq!(headers, expected_headers);
+ }
+
+ #[tokio::test]
+ async fn test_get_default_headers_with_custom_headers() {
+ let server = Server::new_async().await;
+ let mut props = HashMap::new();
+ props.insert("credential".to_string(), "client1:secret1".to_string());
+ props.insert(
+ "header.content-type".to_string(),
+ "application/yaml".to_string(),
Review Comment:
Looks like the header config will overwrite the default one. Are we going to
allow that? We may not overwrite these default headers since it makes less
sense. For example, we may never customize ICEBERG_REST_SPEC_VERSION, it should
come from the lib itself. In this PR, can we focus on allowing users to add
extra headers in this PR. cc @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
