Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887841721 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if i

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
liurenjie1024 merged PR #802: URL: https://github.com/apache/iceberg-rust/pull/802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
liurenjie1024 commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887835700 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be emp

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887055534 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if i

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887055534 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if i

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-16 Thread via GitHub
Fokko commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1886929988 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if it

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885088981 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be empty if i

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
liurenjie1024 commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885062127 ## crates/iceberg/src/io/file_io.rs: ## @@ -165,7 +175,7 @@ impl FileIOBuilder { /// Fetch the scheme string. /// /// The scheme_str will be emp

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885057726 ## crates/iceberg/src/io/file_io.rs: ## @@ -43,10 +43,21 @@ use crate::{Error, ErrorKind, Result}; /// | GCS| `storage-gcs` | `gcs` | #[de

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885057244 ## crates/iceberg/src/io/file_io.rs: ## @@ -43,10 +43,21 @@ use crate::{Error, ErrorKind, Result}; /// | GCS| `storage-gcs` | `gcs` | #[de

Re: [PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
liurenjie1024 commented on code in PR #802: URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885054492 ## crates/iceberg/src/io/file_io.rs: ## @@ -43,10 +43,21 @@ use crate::{Error, ErrorKind, Result}; /// | GCS| `storage-gcs` | `gcs`

[PR] feat: Store file io props to allow re-build it [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo opened a new pull request, #802: URL: https://github.com/apache/iceberg-rust/pull/802 This PR will store file io props to allow users to re-build it. This PR will partly address https://github.com/apache/iceberg-rust/issues/791 --- In a distributed system, we need