liurenjie1024 commented on code in PR #802:
URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885054492
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -43,10 +43,21 @@ use crate::{Error, ErrorKind, Result};
/// | GCS | `storage-gcs` | `gcs` |
#[derive(Clone, Debug)]
pub struct FileIO {
+ scheme: String,
Review Comment:
Instead of storing them, how about we make `FileIOBuilder` clone and
serializable? This could avoid exposing internals and reuse everything there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
