Xuanwo commented on code in PR #802:
URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1885088981
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -165,7 +175,7 @@ impl FileIOBuilder {
/// Fetch the scheme string.
///
/// The scheme_str will be empty if it's None.
- pub(crate) fn into_parts(self) -> (String, HashMap<String, String>) {
+ pub fn into_parts(self) -> (String, HashMap<String, String>) {
Review Comment:
> Should we really expose this? Why not just derive
`Serialize`/`Deserialize` for `FileIOBuilder`?
Unlike `TableMetadata`, `FileIOBuilder` does not have a predefined struct
layout. Implementing `Serialize` or `Deserialize` for `FileIOBuilder` could
lead to users relying on it directly. By exposing `into_parts`, we give users
the flexibility to make their own decisions. This approach also allows us to
modify the API and adjust the internal layout in the future by changing the API
directly without unintentionally breaking users' applications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
