liurenjie1024 commented on code in PR #802:
URL: https://github.com/apache/iceberg-rust/pull/802#discussion_r1887835700
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -165,7 +175,7 @@ impl FileIOBuilder {
/// Fetch the scheme string.
///
/// The scheme_str will be empty if it's None.
- pub(crate) fn into_parts(self) -> (String, HashMap<String, String>) {
+ pub fn into_parts(self) -> (String, HashMap<String, String>) {
Review Comment:
> Implementing Serialize or Deserialize for FileIOBuilder could lead to
users relying on it directly.
That's exactly what I want. But user are not supposed to depend on the
serialized format, but only the ser/de api provided by this library. The pros
of this approach is that we don't need to expose internals fields to user, but
only apis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
