Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-21 Thread via GitHub
zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923610607 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with:

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-21 Thread via GitHub
wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923400782 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: f

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923082582 ## src/iceberg/CMakeLists.txt: ## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUIL

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923078620 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with:

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
zhjwpku commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923076221 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with:

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922579415 ## src/iceberg/CMakeLists.txt: ## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUILD

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922577230 ## src/iceberg/CMakeLists.txt: ## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUILD

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922569711 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: f

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-20 Thread via GitHub
wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922562686 ## .github/workflows/test.yml: ## @@ -80,6 +80,10 @@ jobs: uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 with: f

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-18 Thread via GitHub
wgtmac commented on PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#issuecomment-2599750119 Thanks @zhjwpku for working on this! I will have a try early next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] add libavrocpp_s [iceberg-cpp]

2025-01-18 Thread via GitHub
zhjwpku commented on PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#issuecomment-2599658206 @wgtmac Sadly I came across a Windows ci build issue, I don't have a Windows PC, it would be great if you could help to resolve this problem. The problem is two folds: 1. Windows 2