wgtmac commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922569711
##########
.github/workflows/test.yml:
##########
@@ -80,6 +80,10 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
with:
fetch-depth: 0
+ - name: Install ZLIB
+ shell: cmd
+ run: |
+ powershell -Command "(Invoke-WebRequest -Uri https://git.io/JnHTY
-OutFile install_zlib.bat)"; ./install_zlib.bat; del install_zlib.bat
Review Comment:
Is this script reliable?
Basically I did the following steps to install the zlib library on Windows:
```
git clone https://github.com/madler/zlib.git
cd zlib
cmake -S . -B build -DCMAKE_INSTALL_PREFIX=/tmp/zlib
-DZLIB_BUILD_EXAMPLES=OFF
cmake --build build --config Release
cmake --install build
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
