wgtmac commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923400782
##########
.github/workflows/test.yml:
##########
@@ -80,6 +80,10 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
with:
fetch-depth: 0
+ - name: Install ZLIB
+ shell: cmd
+ run: |
+ powershell -Command "(Invoke-WebRequest -Uri https://git.io/JnHTY
-OutFile install_zlib.bat)"; ./install_zlib.bat; del install_zlib.bat
Review Comment:
What about using `vcpkg`? I believe we may need to add more libraries to the
Windows CI. Using `vcpkg` may be easier. Below is the suggestion from deepseek.
```
name: CI
on: [push]
jobs:
build:
runs-on: windows-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Set up vcpkg
run: |
git clone https://github.com/microsoft/vcpkg.git
.\vcpkg\bootstrap-vcpkg.bat
- name: Install zlib
run: .\vcpkg\vcpkg install zlib:x64-windows
- name: Build your project
run: |
mkdir build
cd build
cmake ..
-DCMAKE_TOOLCHAIN_FILE=../vcpkg/scripts/buildsystems/vcpkg.cmake
cmake --build .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
