wgtmac commented on code in PR #34: URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1922579415
########## src/iceberg/CMakeLists.txt: ########## @@ -17,11 +17,16 @@ set(ICEBERG_SOURCES demo_table.cc) +set(ICEBERG_AVRO_STATIC_BUILD_LIBS) +list(APPEND ICEBERG_AVRO_STATIC_BUILD_LIBS Avro::avro_static) + add_iceberg_lib(iceberg SOURCES ${ICEBERG_SOURCES} PRIVATE_INCLUDES - ${ICEBERG_INCLUDES}) + ${ICEBERG_INCLUDES} + STATIC_LINK_LIBS Review Comment: Should we follow `libiceberg-arrow` to prefer `libavrocpp_s` for static linking and `libavrocpp` for dynamic linking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org