zhjwpku commented on code in PR #34:
URL: https://github.com/apache/iceberg-cpp/pull/34#discussion_r1923610607
##########
.github/workflows/test.yml:
##########
@@ -80,6 +80,10 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
with:
fetch-depth: 0
+ - name: Install ZLIB
+ shell: cmd
+ run: |
+ powershell -Command "(Invoke-WebRequest -Uri https://git.io/JnHTY
-OutFile install_zlib.bat)"; ./install_zlib.bat; del install_zlib.bat
Review Comment:
Let's go this way, good news is that github action windows runner has vcpkg
installed [1]. I also changed the windows runner image to Windows2022, which
resolved the `fatal error C1001: Internal compiler error`. We are using the
newest ubuntu runner version gh-actions supported, so I guess we can use a
slight newer version of windows(the newest is Windows2025).
[1]
https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
