Re: [PR] Write support [iceberg-python]

syun64 commented on PR #41: URL: https://github.com/apache/iceberg-python/pull/41#issuecomment-1919479530 Hi @mkleinbort-ic we've just started [voting](https://lists.apache.org/list.html?d...@iceberg.apache.org) on the first release candidate that incorporates this change -- This is an a

Re: [PR] Write support [iceberg-python]

EternalDeiwos commented on PR #41: URL: https://github.com/apache/iceberg-python/pull/41#issuecomment-1919475189 Check the attached milestone for progress. When those issues are resolved it will be ready for release. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Write support [iceberg-python]

mkleinbort-ic commented on PR #41: URL: https://github.com/apache/iceberg-python/pull/41#issuecomment-1919466577 Is there an ETA for write functionality in the released version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Write support [iceberg-python]

asheeshgarg commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r146669 ## tests/integration/test_writes.py: ## @@ -0,0 +1,387 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Write support [iceberg-python]

sebpretzer commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1465791258 ## tests/integration/test_writes.py: ## @@ -0,0 +1,387 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Write support [iceberg-python]

asheeshgarg commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1465532105 ## tests/integration/test_writes.py: ## @@ -0,0 +1,387 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Write support [iceberg-python]

Fokko commented on PR #41: URL: https://github.com/apache/iceberg-python/pull/41#issuecomment-1898195473 Many thanks again for the great review @rdblue. I went forward and merged it 🙌 Probably we'll improve a bit more on the code-style structure when we add https://github.com/apache/iceber

Re: [PR] Write support [iceberg-python]

Fokko merged PR #41: URL: https://github.com/apache/iceberg-python/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457215849 ## mkdocs/docs/api.md: ## @@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata( The static-table is considered read-only. +## Write support + +With PyIc

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457212225 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457156169 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457138099 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457119174 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

rdblue commented on PR #41: URL: https://github.com/apache/iceberg-python/pull/41#issuecomment-1896944638 @Fokko, this works great and I don't see any blockers so I've approved it. I think there are a few things to consider in terms of how we want to do this moving forward (whether to

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456523045 ## mkdocs/docs/api.md: ## @@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata( The static-table is considered read-only. +## Write support + +With PyI

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456502771 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456498171 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456495179 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456493214 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456491428 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456489014 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456487418 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456486632 ## pyiceberg/table/__init__.py: ## @@ -1935,3 +2043,184 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456478299 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456469457 ## pyiceberg/table/__init__.py: ## @@ -856,6 +909,61 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456467981 ## pyiceberg/table/__init__.py: ## @@ -856,6 +909,61 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456327592 ## mkdocs/docs/api.md: ## @@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata( The static-table is considered read-only. +## Write support + +With PyIc

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1456300895 ## mkdocs/docs/api.md: ## @@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata( The static-table is considered read-only. +## Write support + +With PyI

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1453353542 ## mkdocs/docs/api.md: ## @@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata( The static-table is considered read-only. +## Write support + +With PyIc

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452340468 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452180757 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452175092 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452174491 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452170208 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452163414 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452137292 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452132430 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452113793 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = Fa

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452106699 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1565,56 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452105652 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = Fa

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1452093279 ## pyiceberg/table/__init__.py: ## @@ -797,6 +850,9 @@ def location(self) -> str: def last_sequence_number(self) -> int: return self.metadata.last_sequen

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451838385 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451838116 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451837941 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451837579 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451837508 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451836798 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451836277 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451836112 ## pyiceberg/table/__init__.py: ## @@ -1910,3 +2006,137 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451835863 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451834512 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id]

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451834512 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id]

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451833666 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1565,56 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id]

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451832516 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451832048 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451831352 ## pyiceberg/table/__init__.py: ## @@ -831,6 +887,46 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451829404 ## pyiceberg/table/__init__.py: ## @@ -797,6 +850,9 @@ def location(self) -> str: def last_sequence_number(self) -> int: return self.metadata.last_seque

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451809069 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id]

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451020865 ## pyiceberg/table/snapshots.py: ## @@ -277,23 +278,30 @@ def _truncate_table_summary(summary: Summary, previous_summary: Mapping[str, str }: summary[pr

Re: [PR] Write support [iceberg-python]

syun64 commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1445440825 ## pyiceberg/table/snapshots.py: ## @@ -277,23 +278,30 @@ def _truncate_table_summary(summary: Summary, previous_summary: Mapping[str, str }: summary[p

Re: [PR] Write support [iceberg-python]

syun64 commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1445440825 ## pyiceberg/table/snapshots.py: ## @@ -277,23 +278,30 @@ def _truncate_table_summary(summary: Summary, previous_summary: Mapping[str, str }: summary[p

Re: [PR] Write support [iceberg-python]

robtandy commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1440972324 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id]

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1436371090 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2004,158 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

HonahX commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1435031878 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2004,158 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430744577 ## tests/test_integration_write.py: ## @@ -0,0 +1,357 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430244434 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430138494 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430121458 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430119930 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430119429 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430117206 ## pyiceberg/table/__init__.py: ## @@ -209,6 +221,48 @@ def set_properties(self, **updates: str) -> Transaction: """ return self._append_updates(SetP

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430117518 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -1

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430115587 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = Fa

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1430114586 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = Fa

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429960654 ## pyiceberg/table/__init__.py: ## @@ -209,6 +221,48 @@ def set_properties(self, **updates: str) -> Transaction: """ return self._append_updates(SetP

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429956178 ## pyiceberg/manifest.py: ## @@ -897,9 +902,11 @@ def prepare_manifest(self, manifest_file: ManifestFile) -> ManifestFile: class ManifestListWriterV2(ManifestListW

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429947177 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429946393 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429939138 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429938368 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429902142 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429892223 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

Fokko commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429891452 ## pyiceberg/io/pyarrow.py: ## @@ -1565,13 +1564,54 @@ def fill_parquet_file_metadata( del upper_bounds[field_id] del null_value_counts[field_id] -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429246371 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429246160 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429245920 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429245410 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429245053 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429244908 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429244651 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429241718 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +2001,144 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id * -

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429241217 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429241217 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429240582 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429241025 ## pyiceberg/table/__init__.py: ## @@ -209,6 +221,48 @@ def set_properties(self, **updates: str) -> Transaction: """ return self._append_updates(Set

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429240582 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429240582 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429238390 ## pyiceberg/table/__init__.py: ## @@ -830,6 +884,49 @@ def history(self) -> List[SnapshotLogEntry]: def update_schema(self, allow_incompatible_changes: bool = F

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429236348 ## pyiceberg/table/__init__.py: ## @@ -583,7 +637,7 @@ class AssertRefSnapshotId(TableRequirement): """ type: Literal["assert-ref-snapshot-id"] = Field(d

Re: [PR] Write support [iceberg-python]

rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429233871 ## pyiceberg/table/__init__.py: ## @@ -209,6 +221,48 @@ def set_properties(self, **updates: str) -> Transaction: """ return self._append_updates(Set

  1   2   >