rdblue commented on code in PR #41:
URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1451829404
##########
pyiceberg/table/__init__.py:
##########
@@ -797,6 +850,9 @@ def location(self) -> str:
def last_sequence_number(self) -> int:
return self.metadata.last_sequence_number
+ def next_sequence_number(self) -> int:
+ return self.last_sequence_number + 1 if self.metadata.format_version >
1 else INITIAL_SEQUENCE_NUMBER
Review Comment:
Why have both `next_sequence_number` and `_next_sequence_number` just below
this? They also have slightly different logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
