rdblue commented on code in PR #41: URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1429233871
########## pyiceberg/table/__init__.py: ########## @@ -209,6 +221,48 @@ def set_properties(self, **updates: str) -> Transaction: """ return self._append_updates(SetPropertiesUpdate(updates=updates)) + def add_snapshot(self, snapshot: Snapshot) -> Transaction: Review Comment: I think we also need to make sure that whenever we're updating a table, we also send `AssertTableUUID` to make sure we don't update the wrong one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org