Fokko commented on code in PR #41:
URL: https://github.com/apache/iceberg-python/pull/41#discussion_r1457215849


##########
mkdocs/docs/api.md:
##########
@@ -175,6 +175,104 @@ static_table = StaticTable.from_metadata(
 
 The static-table is considered read-only.
 
+## Write support
+
+With PyIceberg 0.6.0 write support is added through Arrow. Let's consider an 
Arrow Table:

Review Comment:
   Yes, I think this ties into the work that @syun64 is doing where we have to 
make sure that we map the fields correctly, and then I think we can add options 
to massage the Arrow schema into the Iceberg one (which should be leading).
   
   We can create a `visitorWithPartner` that will see if the promotions are 
possible. One that comes to my mind directly, is checking if there are any 
nulls. Arrow marks the schemas as nullable by default, while there are no nulls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to