Fokko merged PR #922:
URL: https://github.com/apache/iceberg-python/pull/922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1684916155
##
pyiceberg/catalog/glue.py:
##
@@ -117,6 +124,12 @@
ICEBERG_FIELD_OPTIONAL = "iceberg.field.optional"
ICEBERG_FIELD_CURRENT = "iceberg.field.current"
+GLUE_PRO
HonahX commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1682245838
##
tests/catalog/test_dynamodb.py:
##
@@ -579,6 +580,74 @@ def test_passing_provided_profile() -> None:
assert test_catalog.dynamodb is mock_session().clie
syun64 commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1681934924
##
pyiceberg/table/__init__.py:
##
@@ -254,6 +254,13 @@ def property_as_bool(properties: Dict[str, str],
property_name: str, default: bo
return value.
kevinjqliu commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1681641793
##
tests/catalog/test_dynamodb.py:
##
@@ -579,6 +580,74 @@ def test_passing_provided_profile() -> None:
assert test_catalog.dynamodb is mock_session().
HonahX commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677395543
##
pyiceberg/catalog/glue.py:
##
@@ -117,6 +124,12 @@
ICEBERG_FIELD_OPTIONAL = "iceberg.field.optional"
ICEBERG_FIELD_CURRENT = "iceberg.field.current"
+GLUE_PR
Fokko commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677113136
##
pyiceberg/catalog/glue.py:
##
@@ -117,6 +124,12 @@
ICEBERG_FIELD_OPTIONAL = "iceberg.field.optional"
ICEBERG_FIELD_CURRENT = "iceberg.field.current"
+GLUE_PRO
HonahX commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677094692
##
mkdocs/docs/configuration.md:
##
@@ -22,35 +22,11 @@ hide:
- under the License.
-->
-# Catalogs
-
-PyIceberg currently has native support for REST, SQL,
HonahX commented on PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#issuecomment-2227281955
> I wonder if we can treat the old property names (i.e. aws_access_key_id)
as an alias for the fallback config (client.access-key-id) versus fully
deprecating it in 0.8.0
@kevi
HonahX commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677091804
##
pyiceberg/io/__init__.py:
##
@@ -320,6 +331,13 @@ def _infer_file_io_from_scheme(path: str, properties:
Properties) -> Optional[Fi
return None
+def _ge
Fokko commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676882383
##
pyiceberg/io/__init__.py:
##
@@ -46,6 +48,10 @@
logger = logging.getLogger(__name__)
+AWS_REGION = "client.region"
Review Comment:
Nice, that's a good fi
Fokko commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676882347
##
pyiceberg/io/__init__.py:
##
@@ -320,6 +331,13 @@ def _infer_file_io_from_scheme(path: str, properties:
Properties) -> Optional[Fi
return None
+def _get
syun64 commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676852897
##
pyiceberg/io/__init__.py:
##
@@ -320,6 +331,13 @@ def _infer_file_io_from_scheme(path: str, properties:
Properties) -> Optional[Fi
return None
+def _ge
syun64 commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676852897
##
pyiceberg/io/__init__.py:
##
@@ -320,6 +331,13 @@ def _infer_file_io_from_scheme(path: str, properties:
Properties) -> Optional[Fi
return None
+def _ge
jayceslesar commented on PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#issuecomment-2226714861
went to generate the mkdocs and spawned
https://github.com/apache/iceberg-python/issues/923 but I think the approach
looks good. The only way to make less repeatable would be to
HonahX commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676596155
##
pyiceberg/io/__init__.py:
##
@@ -46,6 +48,10 @@
logger = logging.getLogger(__name__)
+AWS_REGION = "client.region"
Review Comment:
I chose `client.` for
HonahX opened a new pull request, #922:
URL: https://github.com/apache/iceberg-python/pull/922
There has been many discussions and concerns over the current behavior of
loading AWS credential for glue/dynamo catalog: #892, #515, #570
This PR tries to standardize the property names of
17 matches
Mail list logo
