HonahX commented on code in PR #922: URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677395543
########## pyiceberg/catalog/glue.py: ########## @@ -117,6 +124,12 @@ ICEBERG_FIELD_OPTIONAL = "iceberg.field.optional" ICEBERG_FIELD_CURRENT = "iceberg.field.current" +GLUE_PROFILE_NAME = "glue.profile-name" +GLUE_REGION = "glue.region" +GLUE_ACCESS_KEY_ID = "glue.access-key-id" Review Comment: Thanks for the suggestions! I've updated the doc to explicitly indicating that `glue.*` properties are for Glue Catalog only. I've also added the `s3.*` properties to the example to make this clear. > but my gut feeling is that normally people rely on AWS_ACCESS_KEY_ID to be picked up for both Glue and S3, but I prefer to be able to put this in the ~/.pyiceberg.yaml as well. The `client.*` properties will cover this case. When user set `client.*` properties, both catalog and FileIO can pick up the credentials. However, due to the limitation of pyarrow's S3FileSystem as noted in https://github.com/apache/iceberg-python/issues/570, we cannot yet support a unified `profile-name` property. I added a separate section `Unified AWS Credentials` for the `client.*` properties. Please let me know WDYT. Here are some preview of the updated page:   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
