Fokko commented on code in PR #922: URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1677113136
########## pyiceberg/catalog/glue.py: ########## @@ -117,6 +124,12 @@ ICEBERG_FIELD_OPTIONAL = "iceberg.field.optional" ICEBERG_FIELD_CURRENT = "iceberg.field.current" +GLUE_PROFILE_NAME = "glue.profile-name" +GLUE_REGION = "glue.region" +GLUE_ACCESS_KEY_ID = "glue.access-key-id" Review Comment: How common is it to have a separate `access-key-id` for glue and the table itself? The S3FileIO would not pick up the `glue.access-key-id`: https://github.com/apache/iceberg-python/blob/3f44dfe711e96beda6aa8622cf5b0baffa6eb0f2/pyiceberg/io/pyarrow.py#L349 This way you would need to set both `glue.access-key-id` (which is used for authenticating against Glue), and then you need to set `s3.access-key-id` to ensure that it can access the metadata on the bucket. Maybe good to highlight this on the docs, WDYT? I'm not an AWS expert, but my gut feeling is that normally people rely on `AWS_ACCESS_KEY_ID` to be picked up for both Glue and S3, but I prefer to be able to put this in the `~/.pyiceberg.yaml` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
