kevinjqliu commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1681641793
##########
tests/catalog/test_dynamodb.py:
##########
@@ -579,6 +580,74 @@ def test_passing_provided_profile() -> None:
assert test_catalog.dynamodb is mock_session().client()
+@mock_aws
+def test_passing_glue_session_properties() -> None:
+ session_properties: Properties = {
+ "dynamodb.access-key-id": "dynamodb.access-key-id",
+ "dynamodb.secret-access-key": "dynamodb.secret-access-key",
+ "dynamodb.profile-name": "dynamodb.profile-name",
+ "dynamodb.region": "dynamodb.region",
+ "dynamodb.session-token": "dynamodb.session-token",
+ "client.access-key-id": "client.access-key-id",
+ "client.secret-access-key": "client.secret-access-key",
+ "client.region": "client.region",
+ "client.session-token": "client.session-token",
+ "aws_access_key_id": "aws_access_key_id",
Review Comment:
nit: can make these reuseable. i noticed this is used frequently
```
"aws_access_key_id": "aws_access_key_id",
"aws_secret_access_key": "aws_secret_access_key",
"aws_session_token": "aws_session_token",
"region_name": "region_name",
"profile_name": "profile_name",
```
Perhaps
```
deprecated_properties = {
"aws_access_key_id": "aws_access_key_id",
"aws_secret_access_key": "aws_secret_access_key",
"aws_session_token": "aws_session_token",
"region_name": "region_name",
"profile_name": "profile_name",
}
session_properties = {
...,
**deprecated_properties
}
```
##########
pyiceberg/io/__init__.py:
##########
@@ -46,6 +48,10 @@
logger = logging.getLogger(__name__)
+AWS_REGION = "client.region"
Review Comment:
would be good to highlight this in the PR description!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
