syun64 commented on code in PR #922:
URL: https://github.com/apache/iceberg-python/pull/922#discussion_r1676852897


##########
pyiceberg/io/__init__.py:
##########
@@ -320,6 +331,13 @@ def _infer_file_io_from_scheme(path: str, properties: 
Properties) -> Optional[Fi
     return None
 
 
+def _get_first_property_value(properties: Properties, property_names: 
Tuple[str, ...]) -> Optional[Any]:

Review Comment:
   Nit: Duplicate function defined here and in `pyiceberg/catalog/__init__.py` 
could be consolidated to one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to