nabaskes commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2654798498
@amitgilad3 thank you so much, that was so so fast !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
amitgilad3 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2654746253
@nabaskes - https://github.com/zinking/iceberg/pull/5/
this is an attempt to finish the pr
--
This is an automated message from the Apache Git Service.
To respond to the message
nabaskes commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2654687692
Is the outstanding items here just a matter of doing a rebase? If so, I can
take that up.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
nabaskes commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2627592390
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
amitgilad3 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2626969579
Ill try to finish the pr this weekend, last time i tried we had merge
conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nabaskes commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2625474565
Is this work permanently abandoned? Is there another good way to solve
this, or is this pattern just not really supported?
--
This is an automated message from the Apache Git Service.
github-actions[bot] closed pull request #8797: Spark: support rewrite on
specified target branch
URL: https://github.com/apache/iceberg/pull/8797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2623222633
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2594191922
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2456291421
@amitgilad3 I have some issue doing the rebase with my current computer. so
you probably just copy the branch and doing it on your own repo.
--
This is an automated message from the Ap
jackye1995 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2455701262
I think you might want to rebase the commit against latest main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
amitgilad3 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2449684887
Hey @jackye1995 - i fixed all your comments but for some reason one test
fails and i am not able to reproduce it locally , any chance to assist with
this ?
--
This is an automated
amitgilad3 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2422284309
Tnx for looking into this @jackye1995 , Will fix all the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jackye1995 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2417996073
also @amitgilad3 @zinking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jackye1995 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2417995218
looks like this did not get much attention, @amit-cloudinary I did another
pass, let me know if you can make the updates
--
This is an automated message from the Apache Git Service.
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803785511
##
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##
@@ -171,6 +171,16 @@ default RewriteDataFiles zOrder(String... columns) {
*/
Rewrite
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r180389
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -134,6 +138,17 @@ private RewriteDataFiles checkAndApplyF
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803775302
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -134,6 +138,17 @@ private RewriteDataFiles checkAndApplyF
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r180389
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -134,6 +138,17 @@ private RewriteDataFiles checkAndApplyF
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803777014
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##
@@ -254,6 +258,15 @@ private static void apply(UpdateSchema pendingUpdate,
TableChang
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803775302
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -134,6 +138,17 @@ private RewriteDataFiles checkAndApplyF
jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803766282
##
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##
@@ -171,6 +171,16 @@ default RewriteDataFiles zOrder(String... columns) {
*/
Rewrite
github-actions[bot] commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2403653646
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
amitgilad3 commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2325561162
Hey @szehon-ho @nastra @nk1506 - i fixed you suggestions , can you please
review again.
thanks
--
This is an automated message from the Apache Git Service.
To respond to the mes
amitgilad3 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1702257014
##
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##
@@ -171,6 +171,17 @@ default RewriteDataFiles zOrder(String... columns) {
*/
Rewrite
amitgilad3 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1702205353
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -134,6 +138,21 @@ private RewriteDataFiles checkAndApplyF
amit-cloudinary commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2132978069
> > @zinking - if i can assist with this please let me know (would love to
contribute if possible)
>
> feel free to pick it up here.
Ill give it a try :) ,thanks
--
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2132920372
> @zinking - if i can assist with this please let me know (would love to
contribute if possible)
feel free to pick it up here.
--
This is an automated message from the Apache Gi
amit-cloudinary commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2132899272
@zinking - if i can assist with this please let me know (would love to
contribute if possible)
--
This is an automated message from the Apache Git Service.
To respond to the m
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610904400
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,33 @@ public RewriteDataFilesSparkAction filter(
szehon-ho commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610874491
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -85,6 +87,66 @@ public void testRewriteData
szehon-ho commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610849033
##
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##
@@ -171,6 +171,17 @@ default RewriteDataFiles zOrder(String... columns) {
*/
RewriteD
szehon-ho commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610846416
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##
@@ -254,6 +258,15 @@ private static void apply(UpdateSchema pendingUpdate,
TableChange
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2121627469
ping @nastra for another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
amit-cloudinary commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-2120206876
any updates on this ?? is this something thats going to be merged soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1968104833
let me update the PR, and @nastra can have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
edgarRd commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1967195464
Just checking on the state of this PR, @zinking is there any thing pending
to move this forward? @ajantha-bhat @nastra any remaining concerns?
With branches and [merge-on-read deletes n
ajantha-bhat commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1356348310
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -109,6 +110,8 @@ public InternalRow[] call(InternalRow
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1355083626
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,31 @@ public RewriteDataFilesSparkAction filter(
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1355078213
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -109,6 +110,8 @@ public InternalRow[] call(InternalRow args)
rakesh-das08 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354860039
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -109,6 +110,8 @@ public InternalRow[] call(InternalRow
rakesh-das08 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354860039
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
@@ -109,6 +110,8 @@ public InternalRow[] call(InternalRow
ajantha-bhat commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354746204
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,31 @@ public RewriteDataFilesSparkAction fi
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1757376846
#8762 associating the original issue here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354654198
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFi
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354653413
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,29 @@ public RewriteDataFilesSparkAction filter(
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354616589
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFil
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354615972
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFil
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354511567
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFi
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354506575
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFi
nastra commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1757203967
> > can you also please update the respective docs?
>
> do you mean the branch & tagging doc? anywhere else?
I mean in the Spark procedures section:
https://github.com/apache/
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354492487
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,29 @@ public RewriteDataFilesSparkAction filter(E
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354489402
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,29 @@ public RewriteDataFilesSparkAction filter(E
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354490434
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,29 @@ public RewriteDataFilesSparkAction filter(E
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354486142
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFil
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354480965
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,53 @@ public void testRewriteDataFil
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354478071
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
Review Comment:
it's usually ok to fix something for the lat
zinking commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1757165507
> can you also please update the respective docs?
do you mean the branch & tagging doc? anywhere else?
--
This is an automated message from the Apache Git Service.
To respond to
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r135605
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##
Review Comment:
I prefer it in following ups
--
This i
zinking commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354405286
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
Review Comment:
is that necessary, it's alr
nk1506 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354331345
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
Review Comment:
I think we need to add this for other spark
nastra commented on PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#issuecomment-1757029634
can you also please update the respective docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354320039
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##
@@ -146,13 +148,29 @@ public RewriteDataFilesSparkAction filter(E
nastra commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1354318589
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##
@@ -87,6 +89,51 @@ public void testRewriteDataFil
zinking opened a new pull request, #8797:
URL: https://github.com/apache/iceberg/pull/8797
## why the change
currently, rewrite only happens on main branch.
with the branch functionality it is also useful to conduct rewrite related
tests on branches
## what is changed
65 matches
Mail list logo
