szehon-ho commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610849033
##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -171,6 +171,17 @@ default RewriteDataFiles zOrder(String... columns) {
*/
RewriteDataFiles filter(Expression expression);
+ /**
+ * A user provided branch which the rewrite happens on the target branch can
also be controlled
Review Comment:
Seems like there is a run-on sentence? How about:
```Specify the branch on which the rewrite will be performed.```
It more matches the Iceberg docs on Branches.
https://iceberg.apache.org/docs/1.5.1/spark-writes/#update
Is there anything specific need to call out wrt WAP? (Looks like wap branch
is a Spark concept?)
##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -171,6 +171,17 @@ default RewriteDataFiles zOrder(String... columns) {
*/
RewriteDataFiles filter(Expression expression);
+ /**
+ * A user provided branch which the rewrite happens on the target branch can
also be controlled
Review Comment:
Seems like there is a run-on sentence? How about:
```Specify the branch on which the rewrite will be performed.```
It more matches the Iceberg docs on Branches.
https://iceberg.apache.org/docs/1.5.1/spark-writes/#update
Is there anything specific need to call out wrt WAP? (Looks like wap branch
is a Spark concept and maybe doesnt belong here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
