szehon-ho commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1610874491
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -85,6 +87,66 @@ public void testRewriteDataFilesInEmptyTable() {
assertEquals("Procedure output must match", ImmutableList.of(row(0, 0, 0L,
0)), output);
}
+ @TestTemplate
+ public void testRewriteOnBranchWAP() throws Exception {
+ createPartitionTable();
+ // create 5 files for each partition (c2 = 'foo' and c2 = 'bar')
+ insertData(10);
+ Table table = Spark3Util.loadIcebergTable(spark, tableName);
+ String branch = "op_audit";
+ table.manageSnapshots().createBranch(branch).commit();
+ table.refresh();
+ long branchSnapshotId = table.currentSnapshot().snapshotId();
+ insertData(10);
+ table.refresh();
+ spark.sql(
+ String.format("ALTER TABLE %s SET TBLPROPERTIES
('write.wap.enabled'='true')", tableName));
+ spark.sql(String.format("SET spark.wap.branch = %s", branch));
+ long lastSnapshotId = table.currentSnapshot().snapshotId();
+ List<Object[]> output =
+ sql("CALL %s.system.rewrite_data_files(table => '%s')", catalogName,
tableIdent);
+ assertThat(Arrays.copyOf(output.get(0), 2))
+ .as("Action should rewrite 10 data files and add 2 data files (one per
partition)")
+ .containsExactly(row(10, 2));
+ table.refresh();
+ assertThat(table.refs().get(branch).snapshotId())
+ .as("branch ref should have changed")
+ .isNotEqualTo(branchSnapshotId);
+ assertThat(table.currentSnapshot().snapshotId())
+ .as("rewrite should happen on branch")
Review Comment:
Why not talk about the actual assert like `main branch ref should not have
changed`? Same for below test as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
