jackye1995 commented on code in PR #8797:
URL: https://github.com/apache/iceberg/pull/8797#discussion_r1803777789
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##########
@@ -134,6 +138,17 @@ private RewriteDataFiles checkAndApplyFilter(
return action;
}
+ private RewriteDataFiles checkAndApplyBranch(
+ Table table, Identifier ident, RewriteDataFiles action) {
+ String branchIdent = Spark3Util.extractBranch(ident);
+ SparkWriteConf writeConf = new SparkWriteConf(spark(), table, branchIdent,
Maps.newHashMap());
Review Comment:
probably good to at least initialize it at RewriteDataFilesProcedure level,
and we can see if it can be shared across procedures in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
